RFR: 8358696: Assert with extreme values for -XX:BciProfileWidth [v2]

[Saranya Natarajan]

On Tue, 22 Jul 2025 08:08:28 GMT, Marc Chevalier <mchevalier at openjdk.org> wrote:

>> Saranya Natarajan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   addressing review comment 1
>
> src/hotspot/share/runtime/globals.hpp line 1354:
> 
>> 1352:           range(0, 8)                                                       \
>> 1353:                                                                             \
>> 1354:   develop(intx, BciProfileWidth, 2,                                         \
> 
> Recently, I've seen someone complaining about useless use of `intx`, saying that is brings less readability than a more fixed-width type when not needed. Here, [0, 5000] fits in 16 bits (even signed). One could change that into a simple `int` or something like that.

Since `int` seems to fit the range. I have changed `intx` to `int `

> src/hotspot/share/runtime/globals.hpp line 1357:
> 
>> 1355:           "Number of return bci's to record in ret profile")                \
>> 1356:           range(0, AARCH64_ONLY(1000) NOT_AARCH64(5000))                    \
>> 1357:                                                                             \
> 
> Maybe that's one empty line too much (cf. other spacing just around).

Thank you. I fixed this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26139#discussion_r2222457832
PR Review Comment: https://git.openjdk.org/jdk/pull/26139#discussion_r2222456543