RFR: 8360520: RISC-V: C1: Fix primitive array clone intrinsic regression after JDK-8333154 [v5]
Feilong Jiang
fjiang at openjdk.org
Tue Jul 22 14:35:26 UTC 2025
On Tue, 22 Jul 2025 10:46:47 GMT, Galder Zamarreño <galder at openjdk.org> wrote:
>> Adding new flag check routines seems like a good idea, but it's a bit challenging to choose a name, as there are too many flags for `LIR_OPArrayCopy`[1]. Perhaps something like `should_check_unaligned_or_overlapping` would be suitable?
>>
>> 1. https://github.com/openjdk/jdk/blob/15b5b54ac707ba0d4e473fd6eb02c38a8efe705c/src/hotspot/share/c1/c1_LIR.hpp#L1257-L1271
>
> Hmmm, I don't think I like that name. It's too specific on the flags but does not convey what it's used for. The aim of `flag=0` was to avoid instantiation of array copy stubs, so maybe the name could be `init_flags_for_copy_stubs`? It could be prepended with a `get_` if needs be to avoid confusion.
`init_flags_for_copy_stubs` appears to be misleading, as it suggests we want to generate array copy stubs for those flags.
How about `get_necessary_copy_flags`? We can add other flags if needed in the future.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25976#discussion_r2222749793
More information about the hotspot-compiler-dev
mailing list