RFR: 8348868: AArch64: Add backend support for SelectFromTwoVector [v15]

[Bhavana Kilambi]

On Tue, 22 Jul 2025 09:57:30 GMT, erifan <duke at openjdk.org> wrote:

>> Bhavana Kilambi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Addressed review comments to half the number of match rules
>
> src/hotspot/cpu/aarch64/aarch64.ad line 923:
> 
>> 921:     V24, V24_H, V24_J, V24_K
>> 922: );
>> 923: 
> 
> Not a big matter, but it looks better to me if you can move this change `after line 810` of this file.

Thanks but I feel having all the vector classes (like for vecA, vecX etc) together would be better and keeping the reg_class definitions with other reg_class feels better to me. Hope that's ok?

> src/hotspot/cpu/aarch64/aarch64_vector_ad.m4 line 5181:
> 
>> 5179: %}')dnl
>> 5180: dnl
>> 5181: 
> 
> Remove this blank otherwise two blank lines will be generated. See `src/hotspot/cpu/aarch64/aarch64_vector.ad` line 7180 and line 7181

Hi @erifan Thanks for the comment. This is a good catch. Will update patch soon.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23570#discussion_r2227688969
PR Review Comment: https://git.openjdk.org/jdk/pull/23570#discussion_r2227686648