RFR: 8354244: Use random data in MinMaxRed_Long data arrays
Manuel Hässig
mhaessig at openjdk.org
Thu Jul 24 09:29:55 UTC 2025
On Thu, 24 Jul 2025 06:45:59 GMT, Galder Zamarreño <galder at openjdk.org> wrote:
> Simplified the data used in the tests added in [JDK-8307513](https://bugs.openjdk.org/browse/JDK-8307513). The data does not need to have a specific shape because this test focuses on verifying the IR when vectorization kicks in, and when it does, the data can just be random. Shaping the data to control branch taken/not-taken paths makes sense when CMov macro expansion kicks in instead of vectorization.
>
> When switching to random data I noticed that the test was randomly failing. This was due to potential overflows that result from takin the min/max and then multiplying it by 11, so I've adjusted that section of the test as well.
>
> I've run the test on both aarch64 and x64 platforms where this test would get vectorized. To verify that I made sure the test passed and verified that the jtr output to make sure the IR conditions were matched.
Thank you for this nice simplification, @galderz! It looks good to me as well.
-------------
Marked as reviewed by mhaessig (Committer).
PR Review: https://git.openjdk.org/jdk/pull/26451#pullrequestreview-3050855728
More information about the hotspot-compiler-dev
mailing list