RFR: 8348868: AArch64: Add backend support for SelectFromTwoVector [v16]

Bhavana Kilambi bkilambi at openjdk.org
Thu Jul 24 09:32:06 UTC 2025


On Thu, 24 Jul 2025 08:38:52 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Bhavana Kilambi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Refine comments in c2_MacroAssembler_aarch64.cpp
>
> src/hotspot/cpu/aarch64/aarch64_vector.ad line 261:
> 
>> 259: 
>> 260:         // Because the SVE2 "tbl" instruction is unpredicated and partial operations cannot be generated
>> 261:         // using masks, we currently disable this operation on machines where length_in_bytes <
> 
> Suggestion:
> 
>         // using masks, we disable this operation on machines where length_in_bytes <

Thanks. I use "currently" here because even now we can add support for cases where `length_in_bytes < MaxVectorSize && length_in_bytes > 8` but we currently do not have machines with SVE2 enabled and `length_in_bytes < MaxVectorSize && length_in_bytes > 8` for example - we do not have an SVE2 machine with `MaxVectorSize = 256` to test this operation for `length_in_bytes = 128` but we can add that support in future if such machines become available for testing.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23570#discussion_r2227979550


More information about the hotspot-compiler-dev mailing list