RFR: 8316694: Implement relocation of nmethod within CodeCache [v40]

Chad Rakoczy duke at openjdk.org
Thu Jul 24 18:40:07 UTC 2025


On Wed, 12 Mar 2025 18:49:38 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Chad Rakoczy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use CompiledICLocker instead of CompiledIC_lock
>
> src/hotspot/share/code/nmethod.cpp line 1514:
> 
>> 1512: 
>> 1513:   // Copy all nmethod data outside of header
>> 1514:   memcpy(content_begin(), nm.content_begin(), nm.size() - nm.header_size());
> 
> You would not need it if you `memcpy` whole nmethod.

Decided not to use `memcpy` for the time being https://github.com/openjdk/jdk/pull/23573#discussion_r2220591570

> src/hotspot/share/code/nmethod.cpp line 1595:
> 
>> 1593: }
>> 1594: 
>> 1595: bool nmethod::is_relocatable() const {
> 
> Native nmethods should be skipped too. May be also check `is_in_use()`.

`is_relocatable()` was updated to check `is_java_method()` and `is_in_use()`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23573#discussion_r2229264958
PR Review Comment: https://git.openjdk.org/jdk/pull/23573#discussion_r2229269758


More information about the hotspot-compiler-dev mailing list