RFR: 8316694: Implement relocation of nmethod within CodeCache [v35]
Chad Rakoczy
duke at openjdk.org
Thu Jul 24 19:05:10 UTC 2025
On Sun, 13 Jul 2025 09:36:48 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> Chad Rakoczy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 95 commits:
>>
>> - Typo
>> - Merge branch 'master' into JDK-8316694-Final
>> - Update justification for skipping CallRelocation
>> - Enclose ImmutableDataReferencesCounterSize in parentheses
>> - Let trampolines fix their owners
>> - Merge remote-tracking branch 'origin/master' into JDK-8316694-Final
>> - Update how call sites are fixed
>> - Merge remote-tracking branch 'origin/master' into JDK-8316694-Final
>> - Fix pointer printing
>> - Use set_destination_mt_safe
>> - ... and 85 more: https://git.openjdk.org/jdk/compare/117f0b40...66d73c16
>
> src/hotspot/share/code/nmethod.cpp line 1392:
>
>> 1390:
>> 1391:
>> 1392: nmethod::nmethod(nmethod* nm) : CodeBlob(nm->_name, nm->_kind, nm->_size, nm->_header_size)
>
> Should this be a copy constructor?
>
> nmethod::nmethod(const nmethod &nm) : CodeBlob(nm._name, nm._kind, nm._size, nm._header_size)
>
> Even if we don't make it a copy constructor, it looks like its nmethod argument should be `const`, but I haven't checked very deeply.
The constructor was updated to be a copy constructor
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23573#discussion_r2229328235
More information about the hotspot-compiler-dev
mailing list