RFR: 8278874: tighten VerifyStack constraints [v2]

[Dean Long]

On Thu, 24 Jul 2025 08:07:42 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:

>> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix optimized build
>
> src/hotspot/share/runtime/deoptimization.cpp line 847:
> 
>> 845: 
>> 846: #ifndef PRODUCT
>> 847: #ifdef ASSERT
> 
> Why is both `NOT_PRODUCT` and `ASSERT` needed here? So far, I thought that `ASSERT` implies `NOT_PRODUCT`.

Unfortunately, they are not the same, thanks to "optimized" builds.  We can clean this up if optimizes builds get removed.  See https://bugs.openjdk.org/browse/JDK-8183287.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26121#discussion_r2229334193