RFR: 8362515: RISC-V: cleanup NativeFarCall [v4]
Hamlin Li
mli at openjdk.org
Fri Jul 25 08:39:39 UTC 2025
On Fri, 25 Jul 2025 03:13:34 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>>
>> remove NativeFarCall/RelocCall
>
> src/hotspot/cpu/riscv/nativeInst_riscv.cpp line 51:
>
>> 49: // NativeCall
>> 50: //
>> 51: // Implements direct far calling loading an address from the stub section version of reloc call.
>
> Suggestion: `// Implements indirect far call loading an address from the stub section of reloc call.`
>
> And I think this comment should be moved to immediately before definition of `MacroAssembler::reloc_call` [1].
>
> [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/riscv/macroAssembler_riscv.cpp#L4982
As it still has "far call" which is what we want to cleanup in this pr, and [1] explain the different types of call in more details, I'll just remove this comment to avoid misleading.
[1] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/riscv/macroAssembler_riscv.hpp#L1313
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26370#discussion_r2230513589
More information about the hotspot-compiler-dev
mailing list