RFR: 8358696: Assert with extreme values for -XX:BciProfileWidth [v4]

[Saranya Natarajan]

On Thu, 24 Jul 2025 07:08:24 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:

>> Saranya Natarajan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixing copyright
>
> src/hotspot/share/runtime/globals.hpp line 1356:
> 
>> 1354:   develop(int, BciProfileWidth, 2,                                          \
>> 1355:           "Number of return bci's to record in ret profile")                \
>> 1356:           range(0, AARCH64_ONLY(1000) NOT_AARCH64(5000))                    \
> 
> I'm not too sure of the usual number of returns but even just 1000 sounds quite big as maximum. Do you think we could use that for all architectures?

Thank you for the review. I have tested 1000 by reducing the `InterpreterCodeSize` to the smallest value in all the specified architecture in the source code on both AArch64 and x86. It works for 1000. Hence, I think it should work on all architectures. Do you propose I make it 1000 (or a lesser value) for all architecture ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26139#discussion_r2230592823