RFR: 8364150: RISC-V: Leftover for JDK-8343430 removing old trampoline call [v3]

[Hamlin Li]

On Mon, 28 Jul 2025 13:42:57 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> There is another call of `Relocation::pd_set_call_destination(address x)` from `CallRelocation::set_destination(address x)`, not sure if this `x` passed in from set_destination is also the stub addr?
>
> Sure, I'll take a look. Thanks.
> BTW: I noticed one use of `set_destination` in file ./code/aotCodeCache.cpp. Seems AOT related.
> Maybe you can help confirm that while you are working on enabling AOT support on riscv64?
> 
> 
> ./code/aotCodeCache.cpp:          ((CallRelocation*)iter.reloc())->set_destination(dest);

One suggestion: maybe we can add an additional parameter here for `NativeCall::reloc_set_destination(address dest)` like `is_stub_addr`, so on the path we're sure `dest` is the stub address rather than reloc call destination, we can pass true for `is_stub_addr`, and in other paths we can pass false.
And we can also add an assert in the `is_stub_addr == true` path, like `assert(CodeCache::contains(x), "must");`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26495#discussion_r2236601333