RFR: 8357175: Failure to generate or load AOT code should be handled gracefully [v2]

[Igor Veresov]

On Sun, 1 Jun 2025 00:28:15 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> By default a failed AOT code should be discarded with UL message about it by request (`-Xlog:aot+codecache+*=debug`) and VM and AOT code processing should continue run.
>> 
>> Unless we hit some catastrophic failure: OOM for example. This is similar how JIT compilers behave.
>> 
>> I reordered VM configuration settings checking (`Config::verify()`) so that we switch off AOT code caching type which depends on these VM settings. For example, AOT adapters do not operate on oops - they are not affected by compressed oops settings/encoding. I removed `_objectAlignment` check because CDS already does this check when open archive.
>> 
>> The AOT relocation processing for a blob will skip this blob when corresponding address is not found instead of bailing out VM in product mode. In debug VM it will issue assert so we know about missing address. These changes are in `AOTCodeAddressTable::id_for_address()`
>> 
>> I kept `fatal()` in `AOTCodeAddressTable::for_address_for_id()` for incorrect ID we read from archive. The archive could be corrupted if ID is wrong.
>> 
>> I did small code cleanup/renaming.
>>  
>> Tested: tier1-10
>
> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   address comments

Marked as reviewed by iveresov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/25525#pullrequestreview-2884989001