RFR: 8344942: Template-Based Testing Framework [v61]
Emanuel Peter
epeter at openjdk.org
Mon Jun 2 03:30:24 UTC 2025
On Fri, 30 May 2025 10:39:57 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Merge branch 'JDK-8344942-TemplateFramework-v3' of https://github.com/eme64/jdk into JDK-8344942-TemplateFramework-v3
>> - move verification
>
> Thanks for all the updates and discussions! I've worked my way through the documentation in `Template` and the examples again in some more detail. It's much better and the new explanations are well done, excellent work!
>
> I left some comments here and there but mostly minor things. I will have another look at the implementation - probably only finished by Monday. The design now looks great. I'm glad we could find a good solution now after some more iterations :-)
@chhagedorn Alright, I now have a decent solution for `$$var` and `$1var` etc. I also added tests for it.
These are issues we could continue the conversation, unless you are satisfied with my answers:
https://github.com/openjdk/jdk/pull/24217#discussion_r2115388737
https://github.com/openjdk/jdk/pull/24217#discussion_r2115406391
This is now ready for another review pass 😊
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24217#issuecomment-2928567671
More information about the hotspot-compiler-dev
mailing list