RFR: 8344942: Template-Based Testing Framework [v71]

[Emanuel Peter]

On Mon, 2 Jun 2025 12:54:35 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 91 commits:
>> 
>>  - Merge branch 'master' into JDK-8344942-TemplateFramework-v3
>>  - validation tests
>>  - dollar and hashtag parsing validatiaon
>>  - wip refactor parsing dollar and hashtag
>>  - more fixes from Christian
>>  - more improvements
>>  - more suggestions applied
>>  - good practice
>>  - rename template arguments
>>  - more from Christian
>>  - ... and 81 more: https://git.openjdk.org/jdk/compare/90d6ad01...cb7037e7
>
> test/hotspot/jtreg/compiler/lib/template_framework/NameSet.java line 88:
> 
>> 86:         if (w <= 0) {
>> 87:             return null;
>> 88:         }
> 
> Shouldn't the weight always be positive?

Yes. True. I sometimes just also cover negative values to be a bit more robust... but I can also change it if you prefer that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2121271395