RFR: 8357619: [JVMCI] Revisit phantom_ref parameter in JVMCINMethodData::get_nmethod_mirror [v3]
Erik Österlund
eosterlund at openjdk.org
Mon Jun 2 16:59:57 UTC 2025
On Mon, 2 Jun 2025 16:48:16 GMT, Doug Simon <dnsimon at openjdk.org> wrote:
>> The point of the `phantom_ref` parameter (introduced by [JDK-8234359](https://bugs.openjdk.org/browse/JDK-8234359)) of `JVMCINMethodData::get_nmethod_mirror` is to avoid the special resurrection semantics of a phantom read when reading the field during GC, which is when `JVMCINMethodData::invalidate_nmethod_mirror` can be called.
>> This case can be handled directly in `JVMCINMethodData::invalidate_nmethod_mirror` and so the `phantom_ref` parameter can be removed.
>
> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
>
> fixed typo
Marked as reviewed by eosterlund (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/25488#pullrequestreview-2889256264
More information about the hotspot-compiler-dev
mailing list