RFR: 8316694: Implement relocation of nmethod within CodeCache [v3]
Dean Long
dlong at openjdk.org
Mon Jun 2 23:53:59 UTC 2025
On Mon, 2 Jun 2025 21:49:36 GMT, Chad Rakoczy <duke at openjdk.org> wrote:
>> Thanks. Let's keep current changes as it is with small comment:
>> IMMUTABLE_DATA_REFERENCES is used with `sizeof()` in all places - consider using instead
>> ```
>> #define IMMUTABLE_DATA_REFERENCES_SIZE sizeof(int)
>> ```
>
> I updated it to hold the size based on @vnkozlov suggestion ([source](https://github.com/chadrako/jdk/blob/b0dad6659047553ebee1387939e54ea817b31cb1/src/hotspot/share/code/nmethod.hpp#L172))
>
> @dean-long Are you good with this change and moving the immutable data to a separate class in a seperate issue ([JDK-8358213](https://bugs.openjdk.org/browse/JDK-8358213))?
Sure, fine with me.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23573#discussion_r2122349147
More information about the hotspot-compiler-dev
mailing list