RFR: 8357982: Fix several failing BMI tests with -XX:+UseAPX [v2]
Jatin Bhateja
jbhateja at openjdk.org
Tue Jun 3 02:47:57 UTC 2025
On Tue, 3 Jun 2025 02:41:28 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> A) Patch extends the following tests with hard-coded encoding checks for various BMI instructions to cover REX2 or extended EVEX encodings supported by APX.
>>
>>
>> compiler/intrinsics/bmi/verifycode/AndnTestI.java
>> compiler/intrinsics/bmi/verifycode/AndnTestL.java
>> compiler/intrinsics/bmi/verifycode/BzhiTestI2L.java
>> compiler/intrinsics/bmi/verifycode/LZcntTestL.java
>> compiler/intrinsics/bmi/verifycode/TZcntTestL.java
>>
>>
>> B) After integration of JDK-8349582, which added APX NDD support, AndN instruction selection patterns that expect (Xor SRC, -1) as one of its operands were not getting selected because of a lower-cost generic immediate pattern match; patch fixes this issue through strict predicate checks.
>>
>> Above tests are now passing, validations were carried out using Intel Software Development emulator.
>>
>> Kindly review and share your feedback.
>>
>> Best Regards,
>> Jatin
>
> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>
> Review comments resolutions
Thanks, encoding logic is concentrated in integral instruction tests and is shared with corresponding long variants, extended APX coverage for BLS/R/MSK.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25501#issuecomment-2933177986
More information about the hotspot-compiler-dev
mailing list