RFR: 8344942: Template-Based Testing Framework [v71]

Emanuel Peter epeter at openjdk.org
Tue Jun 3 05:55:12 UTC 2025


On Mon, 2 Jun 2025 18:48:56 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Yes. True. I sometimes just also cover negative values to be a bit more robust... but I can also change it if you prefer that.
>
> I guess if it's never negative, you can still cover it but maybe throw an exception instead?

Ok, I'll add a check/exception :)

>> What exactly do you think is the problem here?
>
> My IDE advises against matching on the raw type `List`. As an alternative you can match on `List<?>`.

Done, I must have been tired yesterday afternoon 🙈 Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2122782343
PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2122776155


More information about the hotspot-compiler-dev mailing list