RFR: 8344942: Template-Based Testing Framework [v71]

[Emanuel Peter]

On Mon, 2 Jun 2025 13:54:10 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 91 commits:
>> 
>>  - Merge branch 'master' into JDK-8344942-TemplateFramework-v3
>>  - validation tests
>>  - dollar and hashtag parsing validatiaon
>>  - wip refactor parsing dollar and hashtag
>>  - more fixes from Christian
>>  - more improvements
>>  - more suggestions applied
>>  - good practice
>>  - rename template arguments
>>  - more from Christian
>>  - ... and 81 more: https://git.openjdk.org/jdk/compare/90d6ad01...cb7037e7
>
> test/hotspot/jtreg/compiler/lib/template_framework/Renderer.java line 338:
> 
>> 336:     }
>> 337: 
>> 338:     private void renderStringWithDollarAndHashtagReplacements(String s) {
> 
> Hard to grasp the logic of that method. But I trust you on that :-) I leave it up to you if you want to improve readability to extract some of the logic to separate methods such that this method becomes easier to understand.

I split out a part and added some more comments / examples.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2122847550