RFR: 8351635: C2 ROR/ROL: assert failed: Long constant expected

[Tobias Hartmann]

On Wed, 28 May 2025 14:19:21 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

> This bug fix patch relaxes the strict assertion check to allow other pattern matches for degenerated long vector ROL/ROR operations with non-constant scalar shift values.  
> 
> Kindly review and share feedback.
> 
> Best Regards,
> Jatin

Looks good to me. I submitted testing and will report back once it passed.

Could you please update the affects version accordingly? I assume this is a regression from [JDK-8271589](https://bugs.openjdk.org/browse/JDK-8271589)?

test/hotspot/jtreg/compiler/vectorapi/TestVectorRotateScalarCount.java line 114:

> 112:     }
> 113: 
> 114: 

Suggestion:

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25493#pullrequestreview-2890886147
PR Review Comment: https://git.openjdk.org/jdk/pull/25493#discussion_r2122854451