RFR: 8358105: RISC-V: Optimize interpreter profile updates
Feilong Jiang
fjiang at openjdk.org
Tue Jun 3 09:29:59 UTC 2025
On Thu, 29 May 2025 11:05:04 GMT, Anjian Wen <wenanjian at openjdk.org> wrote:
> The reason of this patch is same as the x86 and aarch64 but for riscv
> [JDK-8356946](https://bugs.openjdk.org/browse/JDK-8356946)
> [JDK-8357223](https://bugs.openjdk.org/browse/JDK-8357223)
>
>> First, we carry the implementation for counter decrements without using them. This is dead code, and can be purged. Second, we care about overflows for 64-bit for some reason. I think this is a reminiscent of 32-bit x86 support, where we can plausibly have 32-bit counter overflow in a reasonable timeframe. But for 64-bit counter, we need tens of years of constantly bashing the counter to get it to overflow. No other profile counter update code, e.g. in C1, cares about this.
Looks good!
-------------
Marked as reviewed by fjiang (Committer).
PR Review: https://git.openjdk.org/jdk/pull/25520#pullrequestreview-2891497710
More information about the hotspot-compiler-dev
mailing list