RFR: 8344942: Template-Based Testing Framework [v61]

[Emanuel Peter]

On Mon, 2 Jun 2025 12:14:48 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Thanks for all the updates and discussions! I've worked my way through the documentation in `Template` and the examples again in some more detail. It's much better and the new explanations are well done, excellent work! 
>> 
>> I left some comments here and there but mostly minor things. I will have another look at the implementation - probably only finished by Monday. The design now looks great. I'm glad we could find a good solution now after some more iterations :-)
>
>> @chhagedorn Alright, I now have a decent solution for `$$var` and `$1var` etc. I also added tests for it.
>> 
>> These are issues we could continue the conversation, unless you are satisfied with my answers: [#24217 (comment)](https://github.com/openjdk/jdk/pull/24217#discussion_r2115388737) [#24217 (comment)](https://github.com/openjdk/jdk/pull/24217#discussion_r2115406391)
>> 
>> This is now ready for another review pass 😊
> 
> Awesome, thanks for spending some more time with these nasty edge-cases and finding a solution! I had a look at your updates for all my comments, they look good, thanks!
> 
> I'm going to make a pass over the implementation classes now and will have a look at the `Renderer` updates as well :-)

@chhagedorn Thanks a lot for taking the time for the offline meeting! I now updated the two little things we talked about.

Looking forward to another round of review :)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24217#issuecomment-2934840238