RFR: 8344942: Template-Based Testing Framework [v76]

[Emanuel Peter]

On Tue, 3 Jun 2025 13:30:47 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   rename View -> FilteredSet
>
> test/hotspot/jtreg/compiler/lib/template_framework/CodeFrame.java line 95:
> 
>> 93:      * where we would possibly want to make field or variable definitions during the insertion
>> 94:      * that are not just local to the insertion but affect the {@link CodeFrame} that we
>> 95:      * {@link Hook#anchor} earlier and are now {@link Hook#insert}ing into.
> 
> It complains that `addName` cannot be found. Suggestion to use `{@link Template#addDataName}/
>      * {@link Template#addStructuralName}` instead:
>      
> Suggestion:
> 
>      * Creates a special frame, which has a {@link #parent} but uses the {@link NameSet}
>      * from the parent frame, allowing {@link Template#addDataName}/
>      * {@link Template#addStructuralName} to persist in the outer frame when the current frame 
>      * is exited. This is necessary for {@link Hook#insert},  where we would possibly want to 
>      * make field or variable definitions during the insertion that are not just local to the 
>      * insertion but affect the {@link CodeFrame} that we {@link Hook#anchor} earlier and are 
>      * now {@link Hook#insert}ing into.

good catch! I got no complaints because `javadoc` does not look at private classes 🙈

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2124230818