RFR: 8358330: AsmRemarks and DbgStrings clear() method may not get called before their destructor [v2]

[Ashutosh Mehra]

On Tue, 3 Jun 2025 01:29:04 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Ashutosh Mehra has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8358330
>>  - Address review comments
>>    
>>    Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>>  - 8358330: AsmRemarks and DbgStrings clear() method may not get called before their destructor
>>    
>>    Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>
> I am not comfortable that you are changing code not used by AOT.
> Can you consider populate `CodeBlob::_asm_remarks` and `_dbg_strings` after calling `CodeBlob::create()`? Then you don't need temporary `AsmRemarks` and `DbgStrings`.

@vnkozlov I have updated the changes. Can you please review again.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25598#issuecomment-2936000546