RFR: 8357982: Fix several failing BMI tests with -XX:+UseAPX [v3]

[Jatin Bhateja]

On Tue, 3 Jun 2025 17:07:30 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update src/hotspot/cpu/x86/x86_64.ad
>>   
>>   Thanks :-)
>>   
>>   Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>
> src/hotspot/cpu/x86/x86_64.ad line 10620:
> 
>> 10618: instruct xorI_rReg_imm(rRegI dst, immI src, rFlagsReg cr)
>> 10619: %{
>> 10620:   predicate(!UseAPX && n->in(2)->bottom_type()->is_int()->get_con() != -1);
> 
> The PR title seems to suggest the bug is only about -XX:+UseAPX. Why are you changing things for the case !UseAPX?

Hey, AD file change enables AndN inferening, test expects compiler to emit that instruction and has hardcoded encoding checks in place to verify it. So both encoding and AD file changes are necessary to fix this failing test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25501#discussion_r2124477130