RFR: 8352635: Improve inferencing of Float16 operations with constant inputs [v5]
Emanuel Peter
epeter at openjdk.org
Wed Jun 4 06:09:21 UTC 2025
On Wed, 4 Jun 2025 05:54:36 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Extending tests and review resolutions
>
> test/hotspot/jtreg/compiler/c2/irTests/TestFloat16ScalarOperations.java line 63:
>
>> 61:
>> 62: private static Generator<Float> genF = G.uniformFloats(0.0f, 70000.0f);
>> 63: private static Generator<Short> genHF = G.uniformFloat16s(Float.floatToFloat16(-2000.0f), Float.floatToFloat16(2000.0f));
>
> Is there a good reason to only take the uniform distribution?
>
> https://github.com/openjdk/jdk/blob/4a491bef6636441f14fc8bbdedf65063fce038bd/test/hotspot/jtreg/compiler/lib/generators/Generators.java#L102-L105
What about `NaN` and `infty` etc?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24179#discussion_r2125711380
More information about the hotspot-compiler-dev
mailing list