RFR: 8357982: Fix several failing BMI tests with -XX:+UseAPX [v4]

[Emanuel Peter]

On Tue, 3 Jun 2025 18:07:34 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> A) Patch extends the following tests with hard-coded encoding checks for various BMI instructions to cover REX2 or extended EVEX encodings supported by APX. 
>> 
>> 
>>      compiler/intrinsics/bmi/verifycode/AndnTestI.java
>>      compiler/intrinsics/bmi/verifycode/AndnTestL.java
>>      compiler/intrinsics/bmi/verifycode/BzhiTestI2L.java
>>      compiler/intrinsics/bmi/verifycode/LZcntTestL.java
>>      compiler/intrinsics/bmi/verifycode/TZcntTestL.java
>> 
>> 
>> B) After integration of JDK-8349582, which added APX NDD support, AndN instruction selection patterns that expect (Xor SRC, -1) as one of its operands were not getting selected because of a lower-cost generic immediate pattern match; patch fixes this issue through strict predicate checks.
>> 
>> Above tests are now passing, validations were carried out using Intel Software Development emulator.
>> 
>> Kindly review and share your feedback.
>> 
>> Best Regards,
>> Jatin
>
> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments resolutions

src/hotspot/cpu/x86/x86_64.ad line 11326:

> 11324: instruct xorL_rReg_imm(rRegL dst, immL32 src, rFlagsReg cr)
> 11325: %{
> 11326:   predicate(!UseAPX && n->in(2)->bottom_type()->is_long()->get_con() != -1L);

Could you add a similar comment here, like for all the others, please :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25501#discussion_r2125760840