RFR: 8020282: Generated code quality: redundant LEAs in the chained dereferences

[Manuel Hässig]

On Wed, 4 Jun 2025 09:13:34 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:

>> src/hotspot/cpu/x86/peephole_x86_64.cpp line 270:
>> 
>>> 268: // away, this peephole can als recognize the decode as redundant and also remove the spill copy
>>> 269: // if that is only used by the decode.
>>> 270: bool Peephole::lea_remove_redundant(Block* block, int block_index, PhaseCFG* cfg_, PhaseRegAlloc* ra_,
>> 
>> Why do you need `_` suffix?
>
> I don't really need them. I only matched the signature of the other peephole functions.
> 
> We could remove the underline for all peepholes.

This probably comes from the signature in `MachNode`:

https://github.com/openjdk/jdk/blob/7838321b74276e45b92c54904ea31ef70ed9e33f/src/hotspot/share/opto/machnode.hpp#L368-L369

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25471#discussion_r2126287499