RFR: 8020282: Generated code quality: redundant LEAs in the chained dereferences [v2]

[Manuel Hässig]

On Tue, 3 Jun 2025 17:37:41 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Manuel Hässig has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Add comment to benchmark as to why we fix the heap size
>>  - Add missing null chec
>>  - Fix typos
>
> src/hotspot/cpu/x86/peephole_x86_64.cpp line 244:
> 
>> 242: // the DecodeN. However, after matching the DecodeN is added back as the base for the leaP*,
>> 243: // which is nessecary if the oop derived by the leaP* gets added to an OopMap, because OopMaps
>> 244: // cannot contain derived oops with narrow oops as a base.
> 
> Am I correct to assume that if it is referenced in OopMap (which is side table) it will by referenced by some Safepoint node in graph?

Exactly. This is why I can get away with only checking the usages of the decode.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25471#discussion_r2126592531