RFR: 8357982: Fix several failing BMI tests with -XX:+UseAPX [v4]

[Jatin Bhateja]

On Tue, 3 Jun 2025 23:21:52 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments resolutions
>
> src/hotspot/cpu/x86/x86_64.ad line 11341:
> 
>> 11339: %{
>> 11340:   // Strict predicate check to make selection of xorL_rReg_im1_ndd cost agnostic if immL32 src2 is -1.
>> 11341:   predicate(UseAPX && n->in(2)->bottom_type()->is_long()->get_con() != -1L);
> 
> We need a check here for isa_long() before accessing is_long() otherwise is_long() may assert.

Matcher DFA state checks preceding predicate checks will implicitly ensure this

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25501#discussion_r2127155498