RFR: 8357822: C2: Multiple string optimization tests are no longer testing string concatenation optimizations [v2]

[Daniel Skantz]

On Wed, 4 Jun 2025 15:06:19 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Daniel Skantz has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - revert change to TestStringIntrinsics.java
>>  - Update test/hotspot/jtreg/compiler/c2/Test7046096.java
>>    
>>    Co-authored-by: Emanuel Peter <emanuel.peter at oracle.com>
>
> test/hotspot/jtreg/compiler/intrinsics/string/TestStringIntrinsics.java line 1:
> 
>> 1: /*
> 
> Do we need to add a second run at all to this test case? As far as I can see, all `concat*` test cases use explicit string builders and already exercise C2's string concatenation optimizations.

Thanks for checking! I reverted the change to this test as on a second look the benefits of adding the new configuration to it are modest and out of scope.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25610#discussion_r2128300211