RFR: 8354242: VectorAPI: combine vector not operation with compare [v6]
erifan
duke at openjdk.org
Thu Jun 5 09:27:04 UTC 2025
On Wed, 28 May 2025 12:28:20 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> test/hotspot/jtreg/compiler/vectorapi/VectorMaskCompareNotTest.java line 237:
>>
>>> 235: // Byte tests
>>> 236: @Test
>>> 237: @IR(counts = { IRNode.XOR_V_MASK, "= 0", IRNode.XOR_VB, "= 0" },
>>
>> Could you still assert the presence of some other vectors, just to make sure we are indeed getting vectors here?
>
> Not testing for any present vectors makes me a little nervous: what if we just don't get any vectors because inlining fails or something else silly happens?
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24674#discussion_r2128379987
More information about the hotspot-compiler-dev
mailing list