RFR: 8358600: Template-Framework Library: Template for TestFramework test class [v2]

[Emanuel Peter]

On Thu, 5 Jun 2025 11:31:50 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   streamline API to a single render method
>
> Thank you for your continued work on the Template Framework. This seems like good start to the template library. While it already looks good, I have a few small questions :)

@mhaessig Thanks for reviewing! I applied you suggestions :)

> test/hotspot/jtreg/compiler/lib/template_framework/library/TestFrameworkClass.java line 76:
> 
>> 74:     public static String render(final String packageName,
>> 75:                                 final String className,
>> 76:                                 final List<String> imports,
> 
> To eliminate duplicate imports this could also be a `Set`.

Sure, I'll make it a `Set`.

> test/hotspot/jtreg/testlibrary_tests/template_framework/examples/TestWithTestFrameworkClass.java line 135:
> 
>> 133:         ));
>> 134: 
>> 135:         // Create a test for each operator..
> 
> Suggestion:
> 
>         // Create a test for each operator.
> 
> Tiny nit :)

Fixed.

> test/hotspot/jtreg/testlibrary_tests/template_framework/examples/TestWithTestFrameworkClass.java line 145:
> 
>> 143:             // List of imports. Duplicates are permitted.
>> 144:             List.of("compiler.lib.generators.*",
>> 145:                     "compiler.lib.ir_framework.*",
> 
> Suggestion:
> 
> 
> This should not be needed since its imported by default in `TestFrameworkClass`. Or is this a deliberate duplication?

Yes, it was deliberate. But I'll just remove it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25643#issuecomment-2943901270
PR Review Comment: https://git.openjdk.org/jdk/pull/25643#discussion_r2128673497
PR Review Comment: https://git.openjdk.org/jdk/pull/25643#discussion_r2128672040
PR Review Comment: https://git.openjdk.org/jdk/pull/25643#discussion_r2128672889