RFR: 8358600: Template-Framework Library: Template for TestFramework test class [v3]

Manuel Hässig mhaessig at openjdk.org
Thu Jun 5 12:11:53 UTC 2025


On Thu, 5 Jun 2025 12:01:17 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> We might want to write many IR/TestFramework tests, and so I would like to integrate a Template that generates the class, and the user has to only generate a list of tests.
>> 
>> This is a first extension for https://github.com/openjdk/jdk/pull/24217. I had already prototyped it earlier and plan to use it in multiple tests https://github.com/openjdk/jdk/pull/23418 (see `IRTestClass.java`).
>> 
>> https://github.com/openjdk/jdk/blob/dc640cbd8fb8ec76920a7ab52dfe7955ed1d77f2/test/hotspot/jtreg/compiler/lib/template_framework/library/TestFrameworkClass.java#L36-L45
>
> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review suggestions

Thank you for addressing my comments. Looks good to me!

-------------

Marked as reviewed by mhaessig (Author).

PR Review: https://git.openjdk.org/jdk/pull/25643#pullrequestreview-2900057451


More information about the hotspot-compiler-dev mailing list