RFR: 8357982: Fix several failing BMI tests with -XX:+UseAPX [v7]

[Jatin Bhateja]

On Thu, 5 Jun 2025 21:29:46 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review resolutions
>
> src/hotspot/cpu/x86/x86_64.ad line 10636:
> 
>> 10634: %{
>> 10635:   // Strict predicate check to make selection of xorI_rReg_im1_ndd cost agnostic if immI src2 is -1.
>> 10636:   predicate(UseAPX && n->in(2)->bottom_type()->is_int()->get_con() != -1);
> 
> This strict predicate check could be removed.

It's over a general immI match and make selection more robust and agnostic to static patten cost.

> src/hotspot/cpu/x86/x86_64.ad line 11328:
> 
>> 11326: %{
>> 11327:   // Strict predicate check to make selection of xorL_rReg_im1 cost agnostic if immL32 src is -1.
>> 11328:   predicate(!UseAPX && n->in(2)->bottom_type()->is_long()->get_con() != -1L);
> 
> This strict predicate check could be removed.

Please see that checks are only on generic immediate rules and constrain selection.

> src/hotspot/cpu/x86/x86_64.ad line 11343:
> 
>> 11341: %{
>> 11342:   // Strict predicate check to make selection of xorL_rReg_im1_ndd cost agnostic if immL32 src2 is -1.
>> 11343:   predicate(UseAPX && n->in(2)->bottom_type()->is_long()->get_con() != -1L);
> 
> This strict predicate check could be removed.

Same as above.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25501#discussion_r2131603149
PR Review Comment: https://git.openjdk.org/jdk/pull/25501#discussion_r2131603957
PR Review Comment: https://git.openjdk.org/jdk/pull/25501#discussion_r2131604272