RFR: 8357982: Fix several failing BMI tests with -XX:+UseAPX [v8]
    Jatin Bhateja 
    jbhateja at openjdk.org
       
    Fri Jun  6 07:46:32 UTC 2025
    
    
  
> A) Patch extends the following tests with hard-coded encoding checks for various BMI instructions to cover REX2 or extended EVEX encodings supported by APX. 
> 
> 
>      compiler/intrinsics/bmi/verifycode/AndnTestI.java
>      compiler/intrinsics/bmi/verifycode/AndnTestL.java
>      compiler/intrinsics/bmi/verifycode/BzhiTestI2L.java
>      compiler/intrinsics/bmi/verifycode/LZcntTestL.java
>      compiler/intrinsics/bmi/verifycode/TZcntTestL.java
> 
> 
> B) After integration of JDK-8349582, which added APX NDD support, AndN instruction selection patterns that expect (Xor SRC, -1) as one of its operands were not getting selected because of a lower-cost generic immediate pattern match; patch fixes this issue through strict predicate checks.
> 
> Above tests are now passing, validations were carried out using Intel Software Development emulator.
> 
> Kindly review and share your feedback.
> 
> Best Regards,
> Jatin
Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
  Review comments resoltions
-------------
Changes:
  - all: https://git.openjdk.org/jdk/pull/25501/files
  - new: https://git.openjdk.org/jdk/pull/25501/files/45db368d..a89188e1
Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=25501&range=07
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25501&range=06-07
  Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/25501.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25501/head:pull/25501
PR: https://git.openjdk.org/jdk/pull/25501
    
    
More information about the hotspot-compiler-dev
mailing list