RFR: 8356780: PhaseMacroExpand::_has_locks is unused [v3]

[Marc Chevalier]

On Fri, 6 Jun 2025 15:24:11 GMT, Benoît Maillard <duke at openjdk.org> wrote:

>> This PR removes the unused field `PhaseMacroExpand::_has_locks`
>> 
>> Thanks!
>
> Benoît Maillard has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Revert "8356780: Merge both while loops in PhaseMacroExpand::eliminate_macro_nodes"
>    
>    This reverts commit 13deb61de3e2a07d51e3692bb408971f6c18cecf.
>  - Revert "8356780: Remove useless assert"
>    
>    This reverts commit 4e7ee57981b9019d030ac59dc697a2470d8eb5eb.

Seems safe and it does what it says. Interestingly, the cases are now here only for an assert. I guess that's still good to have and it's pretty harmless: in product, the assert won't exist and it will just be an immediate break.

-------------

Marked as reviewed by mchevalier (Committer).

PR Review: https://git.openjdk.org/jdk/pull/25669#pullrequestreview-2905502236