RFR: 8358892: RISC-V: jvm crash when running dacapo sunflow after JDK-8352504 [v3]

[Hamlin Li]

On Tue, 10 Jun 2025 16:13:44 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you help to review this patch?
>> 
>> Thanks!
>> 
>> Currently, this issue is only reproducible with Dacapo sunflow.
>> I tried to construct a simpler jtreg test to reproduce the issue, but can not find a way to do it till now, this task is tracked by https://bugs.openjdk.org/browse/JDK-8359045.
>> 
>> So, currently I can only verify the code by reviewing it.
>> Or maybe it's better to leave it until we find the test?
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   typo

> Hi,
> 
> > We need new implementation for BoolTest::ge/gt, because of NaN cases. It's done.
> 
> Hmm, I don't understand why your first commit ([e5b06b5](https://github.com/openjdk/jdk/commit/e5b06b5621b01dbb557fc21881307c9131f4bb53)) won't work for NaN cases. 

I think the reason is the original assumption is not right about the behaviour of cmov_cmp_fp_ge/gt.

> Do you have more details or maybe a small test case to demo your concern?

You can see failures when running new tests if revert back to first commit of implementation.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25696#issuecomment-2961723788