RFR: 8352635: Improve inferencing of Float16 operations with constant inputs [v5]
Emanuel Peter
epeter at openjdk.org
Wed Jun 11 14:18:40 UTC 2025
On Wed, 11 Jun 2025 14:11:18 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Right ok. The wording `enforce a pattern match` still does not make sense to me. You can `perform` a `pattern match`, but what does it mean to `enforce` it? Can you rephrase please?
>
> Suggestion:
> Suggestion:
>
> // 1. conF must lie within Float16 value range, otherwise we would have rounding issues:
> // Doing the operation in float32 and then rounding is not the same as
> // rounding first and doing the operation in float16.
Do you have tests where the constant is in float16? Which one?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24179#discussion_r2140312169
More information about the hotspot-compiler-dev
mailing list