RFR: 8359064: Expose reason for marking nmethod non-entrant to JVMCI client [v2]
    Doug Simon 
    dnsimon at openjdk.org
       
    Wed Jun 11 19:17:32 UTC 2025
    
    
  
On Wed, 11 Jun 2025 19:01:22 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:
>> src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/code/InstalledCode.java line 152:
>> 
>>> 150:      */
>>> 151:     public void invalidate() {
>>> 152:         invalidate(true, 0);
>> 
>> This assigns `ChangeReason::C1_codepatch` to JVMCI invalidations which does not seem right.
>
> I believe zero is mapped to `UNKNOWN` in the ChangeReason enum, if I'm not very mistaken here?!
Sorry, I was looking at nmethod.hpp in my local source without the changes in this PR. That said, it should probably map to `ChangeReason::JVMCI_invalidate_nmethod` right?
BTW, seems like `ChangeReason::JVMCI_invalidate_nmethod_mirror` is unused and could be deleted.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25706#discussion_r2140896474
    
    
More information about the hotspot-compiler-dev
mailing list