RFR: 8358772: Template-Framework Library: Primitive Types [v3]

[Emanuel Peter]

On Thu, 12 Jun 2025 10:58:50 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review suggestions applied
>
> test/hotspot/jtreg/testlibrary_tests/template_framework/examples/TestPrimitiveTypes.java line 73:
> 
>> 71: 
>> 72:         // p.xyz.InnerTest.main();
>> 73:         comp.invoke("p.xyz.InnerTest", "main", new Object[] {});
> 
> Personally, I would remove the comments here, since this is not a tutorial about the compile framework and the code is self-explanatory (the methods match the comments pretty well).

It is still an example, so I'll leave it. It doesn't hurt. But I may drop them in the future :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25672#discussion_r2142411181