RFR: 8354196: C2: reorder and capitalize phase definition
Marc Chevalier
mchevalier at openjdk.org
Thu Jun 12 11:41:31 UTC 2025
On Thu, 12 Jun 2025 11:10:38 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:
> This PR performs some cleanup and formatting around the phase definitions in C2:
> - the phase descriptions are capitalized according to the [MLA Handbook title case rules](https://en.wikipedia.org/wiki/Title_case#Modern_Language_Association_(MLA)_Handbook),
> - the phases are reordered to be more or less in the order of execution or occurrence in the code,
> - the definitions in `phasetype.hpp` and `CompilePhase.java` are synced,
> - `CompilePhase.java` is aligned for better readability.
>
> This change was tested on:
> - [x] [Github Actions](https://github.com/mhaessig/jdk/actions/runs/15605662671)
> - [x] tier1 plus some Oracle internal testing
More consistent, nice! Everything is still there, or seems to make sense (like I couldn't find anything lost while moving around). Not very sure of the order of phases, but it seems good.
Tip for other reviewers: commit by commit is easier and clearer in this PR.
-------------
Marked as reviewed by mchevalier (Committer).
PR Review: https://git.openjdk.org/jdk/pull/25778#pullrequestreview-2920742632
More information about the hotspot-compiler-dev
mailing list