RFR: 8354196: C2: reorder and capitalize phase definition
Christian Hagedorn
chagedorn at openjdk.org
Thu Jun 12 11:49:28 UTC 2025
On Thu, 12 Jun 2025 11:38:22 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> This PR performs some cleanup and formatting around the phase definitions in C2:
>> - the phase descriptions are capitalized according to the [MLA Handbook title case rules](https://en.wikipedia.org/wiki/Title_case#Modern_Language_Association_(MLA)_Handbook),
>> - the phases are reordered to be more or less in the order of execution or occurrence in the code,
>> - the definitions in `phasetype.hpp` and `CompilePhase.java` are synced,
>> - `CompilePhase.java` is aligned for better readability.
>>
>> This change was tested on:
>> - [x] [Github Actions](https://github.com/mhaessig/jdk/actions/runs/15605662671)
>> - [x] tier1 plus some Oracle internal testing
>
> src/hotspot/share/opto/phasetype.hpp line 100:
>
>> 98: flags(OPTIMIZE_FINISHED, "Optimize Finished") \
>> 99: flags(BEFORE_MATCHING, "Before Matching") \
>> 100: flags(MATCHING, "After Matching") \
>
> Could be named "AFTER_MATCHING" to match the name but as above, could also be part of a separate task.
Nvm, there is already [JDK-8319599](https://bugs.openjdk.org/browse/JDK-8319599) for that.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25778#discussion_r2142515268
More information about the hotspot-compiler-dev
mailing list