RFR: 8358772: Template-Framework Library: Primitive Types [v4]

Manuel Hässig mhaessig at openjdk.org
Thu Jun 12 11:58:29 UTC 2025


On Thu, 12 Jun 2025 11:42:26 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> I would like to add primitive type support to the template framework library.
>> 
>> In follow-up work, we will use these types in random expression generation - but they can also already be useful on their own now.
>> 
>> I encountered an issue with some methods that return `Token` from the `TemplateFramework`, such as `Hook.insert` and `addDataName`. Since `Token` was package private, this class could not be used in some places where automatic type inference is required. I now refactored the code, so that the `Token` is just an empty interface, and all the methods are moved to a separate class `TokenParser`.
>> 
>> Original experiments from here: https://github.com/openjdk/jdk/pull/23418
>
> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   rm static final

Thank you for addressing our comments so quickly. Looks good!

-------------

Marked as reviewed by mhaessig (Author).

PR Review: https://git.openjdk.org/jdk/pull/25672#pullrequestreview-2920833411


More information about the hotspot-compiler-dev mailing list