RFR: 8354196: C2: reorder and capitalize phase definition [v2]

[Manuel Hässig]

On Thu, 12 Jun 2025 11:41:36 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Manuel Hässig has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Split-If is a proper name
>
> test/hotspot/jtreg/compiler/lib/ir_framework/CompilePhase.java line 73:
> 
>> 71:     AFTER_LOOP_UNROLLING(           "After Loop Unrolling"),
>> 72:     BEFORE_SPLIT_IF(                "Before Split-if"),
>> 73:     AFTER_SPLIT_IF(                 "After Split-if"),
> 
> Nit: We might want to name it "Split-If" as being a name? At least we also call it as such in `TraceLoopOpts`:
> https://github.com/openjdk/jdk/blob/65e63b6ab4241fc9d683e2ffa5bfe6e1a30059b6/src/hotspot/share/opto/loopopts.cpp#L1465
> (same for `phasetype.hpp`)

I like the proper name argument. Fixed in 9f3676e4a

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25778#discussion_r2142583277