RFR: 8020282: Generated code quality: redundant LEAs in the chained dereferences [v3]

[Manuel Hässig]

On Thu, 12 Jun 2025 12:42:26 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Manuel Hässig has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Apply typo suggestions
>>   
>>   Co-authored-by: Roberto Castañeda Lozano <robcasloz at users.noreply.github.com>
>
> src/hotspot/cpu/x86/x86_64.ad line 6378:
> 
>> 6376: %}
>> 6377: 
>> 6378: instruct cmovI_rReg_rReg_memUCF_ndd(rRegI dst, cmpOpUCF cop, rFlagsRegUCF cr, rRegI src1, memory src2) 
> 
> Please do not touch unrelated lines. We could remove trailing whitespaces in a separate cleanup RFE.

Reverted in febaf7b1f9a

> src/hotspot/cpu/x86/x86_64.ad line 6761:
> 
>> 6759: %}
>> 6760: 
>> 6761: instruct cmovL_regUCF_ndd(rRegL dst, cmpOpUCF cop, rFlagsRegUCF cr, rRegL src1, rRegL src2) 
> 
> Same here.

Reverted in febaf7b1f9a

> src/hotspot/cpu/x86/x86_64.ad line 6868:
> 
>> 6866: %}
>> 6867: 
>> 6868: instruct cmovL_rReg_rReg_memUCF_ndd(rRegL dst, cmpOpUCF cop, rFlagsRegUCF cr, rRegL src1, memory src2) 
> 
> Same here.

Reverted in febaf7b1f9a

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25471#discussion_r2142866603
PR Review Comment: https://git.openjdk.org/jdk/pull/25471#discussion_r2142866907
PR Review Comment: https://git.openjdk.org/jdk/pull/25471#discussion_r2142867188