RFR: 8356708: C2: loop strip mining expansion doesn't take sunk stores into account [v3]
Roland Westrelin
roland at openjdk.org
Thu Jun 12 15:38:53 UTC 2025
On Thu, 12 Jun 2025 11:57:38 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>>
>> - reviews
>> - Merge branch 'master' into JDK-8356708
>> - Update src/hotspot/share/opto/loopnode.cpp
>>
>> Co-authored-by: Emanuel Peter <emanuel.peter at oracle.com>
>> - Update src/hotspot/share/opto/loopnode.cpp
>>
>> Co-authored-by: Roberto Castañeda Lozano <robcasloz at users.noreply.github.com>
>> - Update src/hotspot/share/opto/loopnode.cpp
>>
>> Co-authored-by: Roberto Castañeda Lozano <robcasloz at users.noreply.github.com>
>> - test & fix
>
> src/hotspot/share/opto/loopnode.cpp line 3010:
>
>> 3008: Node* safepoint = outer_safepoint();
>> 3009: Node* safepoint_mem = safepoint->in(TypeFunc::Memory);
>> 3010: if (safepoint_mem->is_MergeMem()) {
>
> I would have flipped the condition, and made an early exit condition from this. That way, the code is indented one level less. Just a suggestion, feel free to ignore :)
Done in new commit.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25717#discussion_r2143081944
More information about the hotspot-compiler-dev
mailing list