RFR: 8358892: RISC-V: jvm crash when running dacapo sunflow after JDK-8352504 [v11]

Hamlin Li mli at openjdk.org
Fri Jun 13 13:23:42 UTC 2025


On Fri, 13 Jun 2025 13:09:51 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - remove log
>>  - refine comments
>
> src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 1276:
> 
>> 1274: //
>> 1275: // Set dst (CMoveI (Binary cop (CmpF/D op1 op2)) (Binary dst src))
>> 1276: //    1. (op1 lt NaN) => true  => CMove: dst = src
> 
> I think you can rename `NaN` to `op2` and add some words before this like: `If one or both inputs to the compare is a NaN,`.

fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25696#discussion_r2145082415


More information about the hotspot-compiler-dev mailing list