RFR: 8358694: VM asserts if CodeCacheSegmentSize is not a power of 2 [v5]

[Damon Fenacci]

On Thu, 12 Jun 2025 15:58:21 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> Makes sure that JVM exits gracefully when `CodeCacheSegmentSize` is not a power of 2.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove whitespace

Thanks for adding the test @offamitkumar.

test/hotspot/jtreg/compiler/codecache/CodeCacheSegmentSizeTest.java line 38:

> 36: public class CodeCacheSegmentSizeTest {
> 37:     public static void main(String[] args) throws Exception {
> 38:         String codeCacheSegmentSize = (Platform.isS390x() ? "67" : "36"); // invalid value (not power of two)

I think we can check it with any platform (it is not a S390-only constraint). Maybe we could also do it twice, once with and once without a power-of-two size. What do you think?

-------------

PR Review: https://git.openjdk.org/jdk/pull/25708#pullrequestreview-2930798652
PR Review Comment: https://git.openjdk.org/jdk/pull/25708#discussion_r2149151599