RFR: 8356813: Improve Mod(I|L)Node::Value [v4]

Emanuel Peter epeter at openjdk.org
Mon Jun 16 06:59:42 UTC 2025


On Mon, 2 Jun 2025 12:52:47 GMT, Hannes Greule <hgreule at openjdk.org> wrote:

>> @SirYwell I'm not 100% sure here, so please correct me if I'm wrong.
>> You are now always passing in a `jlong` value, so you always use `static inline julong g_uabs(jlong n) { return g_uabs((julong)n); }`, even for `T_INT`.
>
> Yes that's correct, and it should still work due to how negation works for negative inputs.

I think I was quite a bit confused here. Sounds good to me now though :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25254#discussion_r2149178732


More information about the hotspot-compiler-dev mailing list